Re: Reviewers needed for pgjdbc pull requests - Mailing list pgsql-jdbc

From Sehrope Sarkuni
Subject Re: Reviewers needed for pgjdbc pull requests
Date
Msg-id CAH7T-aodMDdy0_WmH4J7JHXQXPE79Re94vBc3maxCDWKz2UJ9A@mail.gmail.com
Whole thread Raw
In response to Re: Reviewers needed for pgjdbc pull requests  (Robert Zenz <robert.zenz@sibvisions.com>)
Responses Re: Reviewers needed for pgjdbc pull requests
List pgsql-jdbc
On Tue, May 15, 2018 at 10:04 AM, Robert Zenz <robert.zenz@sibvisions.com> wrote:
I believe people (myself included) are simply not aware that them reviewing pull
requests would do any good. By definition, pull requests must be reviewed and
can only be merged by these which have the authority to do so. So it seems
superfluous when somebody like me adds a "looks good to me" comment under a PR.
It has to be checked by the merging person anyway.

It's still helpful though. Even simply chiming in to say that a particular feature may be useful without actually reviewing a PR is helpful as it identifies the PRs that reviewers should be focusing on (i.e. stuff that people actually want and will use).

It works in reverse as well. New features mean new code complexity that needs to be maintained over time. Chiming in to say that a feature makes no sense, doesn't cover a edge cases, or that you simply would never use it helps decide if a given change will be worth it in the long run.

-S

pgsql-jdbc by date:

Previous
From: Sehrope Sarkuni
Date:
Subject: Re: Reviewers needed for pgjdbc pull requests
Next
From: Vladimir Sitnikov
Date:
Subject: Re: Reviewers needed for pgjdbc pull requests