Re: [PATCH] Fix getopt_long() argument handling and add tests - Mailing list pgsql-hackers

On Fri, Sep 4, 2026 at 5:58 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
> Nice finds.  I've attached what I have staged for commit.

Thanks for the review!

I tried it out locally and also layered the new test module on top of
your patches.  Everything passes.

> I've tried to simplify the diffs a bit,

Yes, I like your 0002 better. Easier to reason about the state machine
by setting nonopt_start once in the beginning instead of the ternaries.

> and I also got rid of the new test module in favor of adding cases to
> existing test files.  I don't think we need to bother back-patching
> 0001; the bug went undiscovered for ~23 years.

Sounds good.  It was useful for verifying the change but it's a bit
overkill to include.

Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/