Hi Mahendra,
I'm attaching the latest version of the patch. This incorporates
several suggestions Mahendra made. I've also fixed the failing test
and added support for Windows in the test by using perlbin instead of
cat. Here is the list of changes in this version:
1. Changed pipe-command to pip.
2. Added better error handling for invalid command.
3. Added shell escaping in the command before setting it as the file path.
4. I decided to change the mode to PG_BINARY_W for the large object
toc files even in the standard case. If there is a concern, we can
revert to the older version.
5. Added a bunch of new tests for various scenarios and parallelism.
Currently these changes are in a separate commit. After the review, I
can squash the first 3 commits of pg_dump, pg_restore, and the fixes
in one commit.
On Sat, Mar 14, 2026 at 10:37 PM Mahendra Singh Thalor
<mahi6run@gmail.com> wrote:
>
> Comment5: I think we can support this new pipe option with pg_dumpall also as we support directory mode in pg_dumpall
fromv19.
Regarding this, I haven't looked into the details of how that would
work. If the rest look good, we can consider implementing this in
another patch. For the time being, I've skipped this option in
pg_dumpall and the global restore. Let me know what you think.
Thanks
Nitin Motiani,
Google
