Re: pgAdmin 4 commit: Tree view icons - Mailing list pgadmin-hackers
Hi Dave,
PFA patch with resolved all the issues raised.
Issues:
1. Alignment issue: All icons changed from left to center aligned
2. Missing job step icon: Changed in css from .png to .svg for loading the icons
3. Similar look between Jobs and job icon: Updated the icon to differentiate themselves
Also added a white rounded box for the icon placed on popup title bar to differentiate the icon blue color from blue title bar.
Regards,
Chethana kumar
Regards,
Chethana kumar
On Fri, Sep 22, 2017 at 4:06 PM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Hi Dave,On Fri, Sep 22, 2017 at 3:06 PM, Dave Page <dpage@pgadmin.org> wrote:Hi,Couple of issues I spotted in testing this:- pgAgent Job Steps no longer display an icon.It is because of the file naming convention which is not matching with the css call.We need to ensure it once.- pgAdmin jobs and job look like they share the same icon - which is quite off-center.I have resolved this and share the patch.Screenshot attached.--On Thu, Sep 21, 2017 at 11:29 AM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote: Hi,PFA patch which resolves the alignment issues of the tree view icons.Regards,Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
Attachment
pgadmin-hackers by date: