Re: Persist injection points across server restarts - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: Persist injection points across server restarts
Date
Msg-id CAH2L28viB1JdUuBOYn7xTmW16y6dVcExGjCoJQby_-9ore=Ryw@mail.gmail.com
Whole thread Raw
In response to Re: Persist injection points across server restarts  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,
 
Thank you for addressing the review comments.

> It appears that Github CI is reporting failures with
> injection_points/002_data_persist
> failing across all OSes.

I am not sure to see what you are referring to here, based on the
following reports:
https://commitfest.postgresql.org/patch/5731/
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5731
http://cfbot.cputube.org/highlights/all.html

The last failure reported that I know of was due to the addition of
the runtime arguments to the macro INJECTION_POINT().


After applying the v3-patches, I see failure like these:

 
> I wonder if it would be better to include a check for the return value of
> `durable_rename` to
> manage potential failure scenarios.

Or we can be smarter and make this call an ERROR.
 
One issue with this approach is that if a failure occurs during rename, we cannot
unlink(INJ_DUMP_FILE_TMP), because durable_rename does not handle this
before throwing an error.

Should we also consider unlinking the target file INJ_DUMP_FILE in case of an
error during renaming?
Since target files are already synced at the start in the durable_rename() function.

Thank you,
Rahila Syed

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Foreign key validation failure in 18beta1
Next
From: m.litsarev@postgrespro.ru
Date:
Subject: Warning -Wclobbered in PG_TRY(...)