Re: Enhancing Memory Context Statistics Reporting - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: Enhancing Memory Context Statistics Reporting
Date
Msg-id CAH2L28sH3VoQDHE_kqgrmPMxUq7zdWzUWVB6kg-vu+c0_42MpA@mail.gmail.com
Whole thread
In response to Re: Enhancing Memory Context Statistics Reporting  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Enhancing Memory Context Statistics Reporting
List pgsql-hackers
Hi Daniel,

Thank you for the review. All the changes suggested in the v52comments.diff
are incorporated in the attached patches.

+#Server should have thrown error
+$node->psql(
+   'postgres',
+   qq(select pg_get_process_memory_contexts($pid, true);),
+   stderr => \$psql_err);

This test doesn't validate that the server actually errored does it?  (There is
no proposed fix in the attached.)

 
This has been fixed by adding a check for the error returned by the above command.
While at it, I also added another crash test to the file,  This is similar to the existing
test for a client backend crash, but in this scenario, it crashes the server process
instead.

Thank you,
Rahila Syed
Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition
Next
From: Bertrand Drouvot
Date:
Subject: Re: Flush some statistics within running transactions