Request a Demo
Home   >   mailing lists

Re: Buffer locking is special (hints, checksums, AIO writes) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Buffer locking is special (hints, checksums, AIO writes)
Date
Msg-id CAH2-Wznxnr02hCMoDdGM5hwZd+e8SUDdQkH2DcdE34gadRV2pg@mail.gmail.com
Whole thread Raw
In response to Re: Buffer locking is special (hints, checksums, AIO writes)  (Andres Freund <andres@anarazel.de>)
Responses Re: Buffer locking is special (hints, checksums, AIO writes)
List pgsql-hackers
Tree view 
On Tue, Dec 2, 2025 at 7:47 PM Andres Freund <andres@anarazel.de> wrote:
> On 2025-11-25 11:54:00 -0500, Andres Freund wrote:
> > Thanks a lot for that detailed review!  A few questions and comments, before I
> > try to address the comments in the next version.
>
> Here's that new new version, with the following changes

_bt_check_unique will hold an exclusive buffer lock on the page being
LP_DEAD-set in the vast majority of cases. Should we expect your
changes to have no effect at all in that common case?

The BTP_HAS_GARBAGE flag is deprecated these days; we basically don't
use it anymore. How much value might there be in avoiding setting
BTP_HAS_GARBAGE as a way of being able to use BufferSetHintBits16 more
often in nbtree?

--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: PG version is not seen in pg_upgrade test log
Next
From: Andres Freund
Date:
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)