Request a Demo
Home   >   mailing lists

Re: Hash index AM fake LSN oversight - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Hash index AM fake LSN oversight
Date
Msg-id CAH2-WznfA==hUFdN8YEYkhFiTL0X_roQ1MDeCiRygfqZLNDw+A@mail.gmail.com
Whole thread
In response to Re: Hash index AM fake LSN oversight  (Ewan Young <kdbase.hack@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Jul 15, 2026 at 2:47 AM Ewan Young <kdbase.hack@gmail.com> wrote:
> Confirmed -- log_split_page() is the only data-page site e5836f7b left
> without a fake-LSN branch (the _hash_init meta/bitmap paths set the LSN
> under WAL only, but those aren't read concurrently, so that's expected).
> The fix is correct.

Pushed. Thanks for the review!

> One optional cosmetic point: the other fake-LSN sites, including the two
> functions e5836f7b just reworked in this file, hoist recptr out of the
> if and call PageSetLSN once afterwards, rather than once per branch.

I agree that it works slightly better that way; that's what I did in
the committed version.

--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WAL compression setting after PostgreSQL LZ4 default change
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: ci: namespace ccache by PostgreSQL major version