Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date
Msg-id CAH2-WznLDZQHYj48H6bLSHw=eY9gP1jmB48_Ope=mPkzNH5DSQ@mail.gmail.com
Whole thread Raw
In response to Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Oct 17, 2025 at 1:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I don't have a problem with the change you made.  I do have a problem
> with baza having spun up this check before we settled on a way to
> manage it.

+1.

> AFAIK we don't have any process by which we can decide
> that a reported ABI change is acceptable and then clear the failure.
> There was some discussion of how to control it [1], but nothing's been
> done yet.

The fact that this is now causing problems was entirely predictable
(and was in fact predicted). Having a way to suppress individual
warnings that are deemed to be invalid is 100% essential if we're
detecting ABI changes on a buildfarm animal like this.

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Next
From: Ranier Vilela
Date:
Subject: Re: Getting the SQLSTATE after a failed connection