Re: pgsql: pgstat: run pgindent on pgstat.c/h. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: pgstat: run pgindent on pgstat.c/h.
Date
Msg-id CAH2-WzmuFCFg+FX31Z_Qz1cxdzV0RDK491fgB-hg-=4DJsAdww@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: pgstat: run pgindent on pgstat.c/h.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: pgstat: run pgindent on pgstat.c/h.
List pgsql-committers
On Sat, Mar 19, 2022 at 12:27 PM Andres Freund <andres@anarazel.de> wrote:
> I was actually wondering what our policy around that is for smaller runs like
> this. Do we do that in bulk occasionally? Just after?

That's not completely clear, but I think that it makes sense to do it
right afterwards. We haven't been maintaining a .git-blame-ignore-revs
file for long enough, so maybe the workflow needs to be refined. Perhaps there
should *also* be something in the RELEASE_CHANGES files about looking
for overlooked pgindent files, too.

It's not the end of the world if somebody forgets to do this,
obviously. Ideally there would be some kind of reminder built into the
pgindent tooling to make it less likely.

> We're also missing the recent, a bit larger, reindent that Heikki did:

>     Run pgindent on xlog.c.

I missed that one.


--
Peter Geoghegan



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: pgstat: run pgindent on pgstat.c/h.
Next
From: Andres Freund
Date:
Subject: pgsql: Add a few recent and not so recent revs to git-blame-ignore-revs