Request a Demo
Home   >   mailing lists

Re: index prefetching - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: index prefetching
Date
Msg-id CAH2-WzmpuPFPxV5nUQNs1skeROr69w_bDtvwr=ybCCrX9_GANw@mail.gmail.com
Whole thread
In response to Re: index prefetching  (SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>)
List pgsql-hackers
Tree view 
On Sun, Mar 29, 2026 at 2:16 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> I am still reviewing / understanding the patch, a couple quick comments based on my review.
>
> 1. Looks like off-by-one in the for loop in the patch v18-0015-WIP-aio-io_uring-Use-IO-size-not-IO-queue-to-tri.patch

You're right. Andres independently fixed this bug on our working
branch just yesterday.

> 2. NIT comment: _bt_endpoint return type changed to IndexScanBatch from bool in the patch
v18-0005-Add-interfaces-that-enable-index-prefetching.patch.
> But the places it is returning false would be  good to replace with NULL. Though false is treat as 0/NULL and no
compilererrors, it improves the readability of the code. 

I agree. This was a simple oversight, not a deliberate choice. It'll
be fixed in the next version.

Thanks
--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: KAZAR Ayoub
Date:
Subject: Re: Add pg_stat_vfdcache view for VFD cache statistics
Next
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: Introduce XID age based replication slot invalidation