Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] amcheck (B-Tree integrity checking tool) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [HACKERS] amcheck (B-Tree integrity checking tool)
Date
Msg-id CAH2-WzkJsUaKhzvUFDjzEa9k86LVkf3Q7gU0noH5JWMeO2KfbA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] amcheck (B-Tree integrity checking tool)  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] amcheck (B-Tree integrity checking tool)  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Tree view 
On Thu, Mar 9, 2017 at 7:10 PM, Andres Freund <andres@anarazel.de> wrote:
>>   verify_nbtree.obj : error LNK2001: unresolved external symbol
>> RecentGlobalXmin
>> [C:\buildfarm\buildenv\HEAD\pgsql.build\amcheck.vcxproj]
>>
>> Rather than marking RecentGlobalXmin as PGDLLIMPORT, I'd rather just
>> remove the documenting assertion and leave that comment as-is. I'll
>> work on a patch for this soon.
>
> Hm - I think it's fair to export RecentGlobalXmin, given that we
> obviously use it across modules in core code.  I see very little reason
> not to export it.

Well, the assertion is completely useless as anything but documentation...


-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] amcheck (B-Tree integrity checking tool)
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Write Ahead Logging for Hash Indexes