Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings
Date
Msg-id CAH2-Wzk-LH8Ln235hB4Y39EDFE6Bvb2bxKxMn_Ru4GjJNxTHnA@mail.gmail.com
Whole thread Raw
In response to Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings
List pgsql-hackers
On Tue, Jul 15, 2025 at 7:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> There are a lot of them, for sure.

It's *very* common for switch statements to have a "can't happen"
elog(ERROR) as their default block. Many of these default blocks also
initialize related variables to placate the compiler.

> I'd be a bit worried about
> creating a back-patching mine-field.  But maybe these are all
> in spots we're unlikely to touch?

That seems like much less of a problem for a purely subtractive change
such as this.

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings
Next
From: Michael Paquier
Date:
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX