Re: s/pg_attribute_always_inline/pg_always_inline/? - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: s/pg_attribute_always_inline/pg_always_inline/?
Date
Msg-id CAH2-Wzk-=_jppioxmiFSo=a5NGNoVkV2AYt_xKU+qPOQiQtLzg@mail.gmail.com
Whole thread
In response to s/pg_attribute_always_inline/pg_always_inline/?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Wed, Apr 8, 2026 at 5:09 PM Andres Freund <andres@anarazel.de> wrote:
> When reviewing the index prefetching patch I got a bit dismayed at how long
> pg_attribute_always_inline is due to the way it triggers pgindent to format
> stuff.

I had to significantly reorder function prototypes to avoid overly
long prototypes that had pg_attribute_always_inline. While perhaps not
strictly necessary, we shouldn't have to work around the fact that
pg_attribute_always_inline is an absurdly verbose symbol name.

> I propose that we remove the _attribute_ part of the name.

+1

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529
Next
From: Sami Imseih
Date:
Subject: Re: Add pg_stat_autovacuum_priority