Re: xid wraparound danger due to INDEX_CLEANUP false - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: xid wraparound danger due to INDEX_CLEANUP false
Date
Msg-id CAH2-Wz=WWY5RS7sKMa51urv_r-ApZftWLZkZ8Ek6mVaUJdMXkw@mail.gmail.com
Whole thread Raw
In response to Re: xid wraparound danger due to INDEX_CLEANUP false  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: xid wraparound danger due to INDEX_CLEANUP false  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
List pgsql-hackers
On Tue, May 5, 2020 at 2:52 PM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
> So IIUC the problem is that since we skip both,
> oldst_btpo_xact could be seen as a "future" xid during vacuum. Which
> will be a cause of that vacuum misses pages which can actually be
> recycled.

This is also my understanding of the problem.

> I think we can fix this issue by calling vacuumcleanup callback when
> an anti-wraparound vacuum even if INDEX_CLEANUP is false. That way we can
> let index AM make decisions whether doing cleanup index at least once
> until XID wraparound, same as before.

+1

Can you work on a patch?

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: xid wraparound danger due to INDEX_CLEANUP false
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Postgres Windows build system doesn't work with python installedin Program Files