On Fri, Jul 23, 2021 at 3:30 PM Noah Misch <noah@leadboat.com> wrote:
> It could be okay, but I think it's better to add the test under amcheck. You
> could still use pgbench in the test.
+1. Writing the test that way seems more robust. If somebody writes a
patch that reintroduces a similar though distinct bug, then it seems
more likely to be caught. In other words, there is less of a danger of
the test over-specifying what incorrect means if it uses amcheck
directly.
--
Peter Geoghegan