Postgres Pro
Downloads
Home   >   mailing lists

Re: Parallel bt build crashes when DSM_NONE - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Parallel bt build crashes when DSM_NONE
Date
Msg-id CAH2-Wz=Arcfz50TFxSoNpR1-mSDFpy+Zxd3BtBm3FFYc5GaYyQ@mail.gmail.com
Whole thread Raw
In response to Parallel bt build crashes when DSM_NONE  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Parallel bt build crashes when DSM_NONE  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Feb 9, 2018 at 12:06 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> I happend to find that server crashes during regtest when
> DSM_NONE is enforced. The attached patch fixes that.
>
> The cause is the fact that _bt_spools_heapscan runs
> _bt_begin_parallel() even if dynamic_shared_memory_type is
> DSM_NONE. It is because plan_create_index_workers() is ignoring
> dynamic_shared_memory_type.

I think that your patch does the right thing.
plan_create_index_workers() is supposed to take care of parallel
safety, and this is a parallel safety issue.

Thanks
-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: CALL stmt, ERROR: unrecognized node type: 113 bug
Next
From: Mat Arye
Date:
Subject: Re: Minor version upgrades and extension packaging