Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.
Date
Msg-id CAH2-Wz=2PjF4As8dWECArsXxLKganYmQ-s0UeGqHHbHhqDKqeA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.
List pgsql-committers
Tree view 
On Mon, Jun 28, 2021 at 9:47 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The instructions for "Starting a New Development Cycle" perhaps need
> a specific "see src/tools/pgindent/README".  I'd be inclined to
> remove the separate mention of .git-blame-ignore-revs from "Pre-Beta
> Tasks", too.  If you didn't read pgindent/README you might miss
> more than just this.

How about the approach taken in the attached patch?

I think that leaving the snippet on adding new entries to the file at
the top of the file is the right approach. I haven't changed that. I
do point this out explicitly, though.

-- 
Peter Geoghegan
Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't use abort(3) in libpq's fe-print.c.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.