Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Improve nbtree skip scan primitive scan scheduling. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
Date
Msg-id CAH2-Wz=1eJZMSMoACDW2oLcxd8QUtKQS7HuYtqx98LLji+WKuQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Improve nbtree skip scan primitive scan scheduling.  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
List pgsql-committers
Tree view 
On Sat, Apr 26, 2025 at 10:39 PM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> Peter, Matthias, thanks kindly for the good work on skipscans!

Thanks!

> I found a test case which fails after commit 21a152b37f36c9563d1b0b058fe1436baf578b4c.  Please find a reproducible
testcase, attached. 

The bug isn't actually in commit
21a152b37f36c9563d1b0b058fe1436baf578b4c -- it's just an accident that
the mechanism added by that commit happens to make your test case
fail. The underlying issue was introduced in commit 8a510275, "Further
optimize nbtree search scan key comparisons".

This looks to have been a silly oversight in our handling of NULL
tuple datums within _bt_check_compare. Attached provisional fix makes
your test case pass.

--
Peter Geoghegan
Attachment

pgsql-committers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
Next
From: Bertrand Drouvot
Date:
Subject: Re: clang-tidy complaints