XACT_EVENT for 'commit prepared' - Mailing list pgsql-hackers

From Xiaoran Wang
Subject XACT_EVENT for 'commit prepared'
Date
Msg-id CAGjhLkNuE5z=0ZOaO8veqcC8pq+rOnavoVHgoPqKqRnSXzvYmg@mail.gmail.com
Whole thread Raw
Responses Re: XACT_EVENT for 'commit prepared'
List pgsql-hackers
Hi hackers, 

I found that in enum XactEvent, there is  'XACT_EVENT_PREPARE'  for 'prepare transaction', but there is no event for 'commit prepared' or 'rollback prepared'.

For the following SQL:
------------------------------------------------
begin;
create table test(a int);
PREPARE TRANSACTION 'foo';
rollback prepared 'foo';
-------------------------------------------------
When executing ' rollback prepared 'foo'; ', I expected to get 'XACT_EVENT_ABORT', but actually, 
the event type is 'XACT_EVENT_COMMIT'. 

I think XACT_EVENT_COMMIT_PREPARED and XACT_EVENT_ROLLBACK_PREPARED can be added in function 'FinishPreparedTransaction'

I'm confused why there are no related events for them. 

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade
Next
From: Dilip Kumar
Date:
Subject: Re: Compress ReorderBuffer spill files using LZ4