On 2025/5/27 11:54, Michael Paquier wrote: > On Tue, May 27, 2025 at 11:06:46AM +0800, Quan Zongliang wrote: >> I noticed that the subtype of AlterDomainStmt is directly using constants in >> the code. It is not conducive to the maintenance and reading of the code. >> Based on the definition of AlterTableType, use "AD_" as the prefix. Define >> several macros to replace the original characters. >> The subtype of AlterTableCmd is defined using an enumeration. The subtypes >> of AlterDomainStmt are relatively few in number, and the original definition >> uses characters. These definitions still use characters and maintain the >> values unchanged. If some plugins or tools are also processing >> AlterDomainStmt, there will be no errors. > > Sounds like a good idea. As far as I can see after a closer lookup at > the tree, you have updated all the code paths that matter for this > change, and you have added a CF entry: > https://commitfest.postgresql.org/patch/5780/ > > +#define AD_VaidateConstraint 'V' /* VALIDATE CONSTRAINT */ > Updated Thank you.
