Re: Vectorize pg_visibility.pg_visibility_map_summary - Mailing list pgsql-hackers

From wenhui qiu
Subject Re: Vectorize pg_visibility.pg_visibility_map_summary
Date
Msg-id CAGjGUAJa2jRepQT0BjeXtAqne-zN-bQ2wOSkrrUswzeya6W-og@mail.gmail.com
Whole thread Raw
In response to Re: Vectorize pg_visibility.pg_visibility_map_summary  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
List pgsql-hackers
Hi 

> It looks like a reasonable idea as it also simplifies the
> pg_visibility_map_summary() function. I'm going to push it, barring
> any objections.
Obviously no objections, Using visibilitymap_count() simplifies the code and improves performance, with no behavior change.

Thanks 


On Tue, Dec 23, 2025 at 6:17 AM Matthias van de Meent <boekewurm+postgres@gmail.com> wrote:
Hi,

On Mon, 22 Dec 2025 at 23:04, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Mon, Dec 22, 2025 at 1:28 PM Matthias van de Meent
> <boekewurm+postgres@gmail.com> wrote:
> > Here's one small patch that makes it use the visibilitymap_count() API
> > for pg_visibility_map_summary(), replacing its own bespoke counting
> > mechanism with the primary implementation that has vectorized
> > optimizations, thus reducing the overhead of
> > pg_visibility_map_summary.
> >
>
> It looks like a reasonable idea as it also simplifies the
> pg_visibility_map_summary() function. I'm going to push it, barring
> any objections.

Obviously no objections from me, and, thanks!


Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)


pgsql-hackers by date:

Previous
From: "zengman"
Date:
Subject: Re: Refactor query normalization into core query jumbling
Next
From: Chao Li
Date:
Subject: Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS?