Re: Resetting recovery target parameters in pg_createsubscriber - Mailing list pgsql-hackers

From Alena Vinter
Subject Re: Resetting recovery target parameters in pg_createsubscriber
Date
Msg-id CAGWv16Lm8mp9pH7yHxfz_XeMBOqPFGc-vGCRtb1n_KN756oU4Q@mail.gmail.com
Whole thread Raw
In response to Re: Resetting recovery target parameters in pg_createsubscriber  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Resetting recovery target parameters in pg_createsubscriber
RE: Resetting recovery target parameters in pg_createsubscriber
List pgsql-hackers
Hi,

> In short, I disagree with what you are doing here: we should take the
> extra step and clean up anything that's been created by the tool when
> we know we can safely do so

I got your point, thanks for pointing to the `pg_rewind` case. I've attached a new version of the patches. I've changed `ReplaceRecoveryConfig` a little bit -- now it returns false in case of an error instead of exiting.

Best wishes,
Alena Vinter
Attachment

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: CREATE TABLE LIKE INCLUDING TRIGGERS
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication