Re: Resetting recovery target parameters in pg_createsubscriber - Mailing list pgsql-hackers

From Alyona Vinter
Subject Re: Resetting recovery target parameters in pg_createsubscriber
Date
Msg-id CAGWv16KPjMdu2k-xc+hZcOs_8+5GyvGGtH_y13OcqOpde6e-BQ@mail.gmail.com
Whole thread Raw
In response to RE: Resetting recovery target parameters in pg_createsubscriber  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
Dear Hayato, 

Thank you for the review! My apologies for the error in the patch -- it looks like I accidentally modified it before sending =(. I've attached the fixed versions below. 

> Regarding patch content, your patch restores the postgresql.auto.conf after the
> command runs. Initially I felt that it is enough to set below GUCs becasue only
> they are changed from the default. Is there a reason why you fully restore them?

I just found it easier to restore the original state of 'postgresql.auto.conf', as removing parameters from the file resets them to their default values. This approach achieves the same final state without having to explicitly set each one.
Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Appetite for syntactic sugar to match result set columns to UDT fields?
Next
From: Tom Lane
Date:
Subject: Re: Appetite for syntactic sugar to match result set columns to UDT fields?