Request a Demo
Home   >   mailing lists

Re: [PATCH] pg_surgery: check the page header and line pointers - Mailing list pgsql-hackers

From shihao zhong
Subject Re: [PATCH] pg_surgery: check the page header and line pointers
Date
Msg-id CAGRkXqT_V5wxz2L_MFp1QYSsEQpQsrSUDxFu55VCgBzH9=Yv2g@mail.gmail.com
Whole thread
In response to [PATCH] pg_surgery: check the page header and line pointers  (shihao zhong <zhong950419@gmail.com>)
List pgsql-hackers
Tree view
Hi Andrey,

Thanks for reviewing!

> I think heap_force_freeze() needs one more check.  

I agree with you, check added

> See amcheck tests fro details, but I'm not sure it actually
> worth the trouble here.

In my opinion, every change we made should have some
kind of regression tests. I understand there are resource 
limit for machines but I believe engineering wise this is the
right way to do.
I added a TAP test to simulate a corrupt page.

Thanks
Shihao


Attachment

pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Direct TOAST v2, faster, smaller and no migration needed
Next
From: Andrey Borodin
Date:
Subject: Re: [PATCH v1 0/7] Wait event timing and tracing instrumentation