Request a Demo
Home   >   mailing lists

Re: REPACK: warn about skipping foreign partitions - Mailing list pgsql-hackers

From shihao zhong
Subject Re: REPACK: warn about skipping foreign partitions
Date
Msg-id CAGRkXqT4-X1_4WMx+V9MA_69pM_fGrUhst7EhR5YwPD9kUoeTA@mail.gmail.com
Whole thread
List pgsql-hackers
Tree view
Hi Zsolt,

A few small things.

In the non index case the new find_all_inheritors call returns the
same list as the one right below it. You could reuse it there.

For the docs I would write "are skipped with a warning".

The last test, the parent with only foreign partitions, goes through
the same code path as the one before it. I would drop it.

Otherwise it looks good to me. 

Thanks
Shihao

pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: [PATCH] add missed tests for gist index
Next
From: Viktor Holmberg
Date:
Subject: Re: ON CONFLICT DO SELECT returns rows hidden by a view