Re: BUG #19686: Rolling back SET TABLESPACE - Mailing list pgsql-hackers

From shihao zhong
Subject Re: BUG #19686: Rolling back SET TABLESPACE
Date
Msg-id CAGRkXqSFUpNaYXt_EOiG9wNzXK6GCGaHZviGryfGRczJ-GqNfA@mail.gmail.com
Whole thread
In response to Re: BUG #19686: Rolling back SET TABLESPACE  (Manu <manuelreyesbravo@gmail.com>)
Responses Re: BUG #19686: Rolling back SET TABLESPACE
List pgsql-hackers
Hi Manu,

I reviewed v2 and it looks correct. I asked Fable to test rollback,
savepoints, 2PC, crash recovery and a standby, and they all pass. The
test fails without the fix.

v2 also fixes SET TABLESPACE, TRUNCATE, ROLLBACK, which empties the
index on master.

Alexandre's full tablespace case does fail with v2. Moving the
indexes first works.

It applies to 16 and up. 14 and 15 need the old RelFileNode names.

Thanks,
Shihao

pgsql-hackers by date:

Previous
From: Joao Detomini
Date:
Subject: Re: tuplesort_putdatum() does not account for tuple memory
Next
From: Zhijie Hou
Date:
Subject: Re: Fix apply worker crash when subscriber table has only a deferrable primary key