Re: pg_resetwal: refuse to run when backup_label exists - Mailing list pgsql-hackers

From shihao zhong
Subject Re: pg_resetwal: refuse to run when backup_label exists
Date
Msg-id CAGRkXqQ7D9zRONZdQTV3QudzOL=1g7hBtGv3E+Gs+aQ=bhDL2Q@mail.gmail.com
Whole thread
In response to pg_resetwal: refuse to run when backup_label exists  (shihao zhong <zhong950419@gmail.com>)
List pgsql-hackers
i Tinh,

Thanks for testing.

> One possible test enhancement would be to assert that pg_control,
> the WAL files, and backup_label remain unchanged after each refusal.

I would leave that out. The check runs before pg_resetwal reads
pg_control, right after the postmaster.pid check, so nothing has been
written at that point. The postmaster.pid refusal has no such test
either. I did check by hand, and all three are unchanged after each
refusal.

Thanks,
Shihao

pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: Assert failure in find_var_for_subquery_tle
Next
From: shihao zhong
Date:
Subject: Re: examine_variable ignored CollateExpr