Re: CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ... - Mailing list pgsql-hackers

Hi All,

- Patch got applied cleanly.
- Regression make check run fine.
- Patch covered the documentation changes

Here are few comments:

1) What the need of following change:

diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c
index bcec173..9fe6855 100644
--- a/src/backend/storage/lmgr/lwlock.c
+++ b/src/backend/storage/lmgr/lwlock.c
@@ -1005,12 +1005,6 @@ LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval)
             lock->tail = proc;
         lock->head = proc;
 
-        /*
-         * Set releaseOK, to make sure we get woken up as soon as the lock is
-         * released.
-         */
-        lock->releaseOK = true;
-
         /* Can release the mutex now */
         SpinLockRelease(&lock->mutex);
 

It doesn't look like related to this patch.

2)

diff --git a/src/bin/psql/help.c b/src/bin/psql/help.c
index ae5fe88..4d11952 100644
--- a/src/bin/psql/help.c
+++ b/src/bin/psql/help.c
@@ -247,7 +247,7 @@ slashUsage(unsigned short int pager)
     fprintf(output, _("  \\f [STRING]            show or set field separator for unaligned query output\n"));
     fprintf(output, _("  \\H                     toggle HTML output mode (currently %s)\n"),
             ON(pset.popt.topt.format == PRINT_HTML));
-    fprintf(output, _("  \\pset [NAME [VALUE]]   set table output option\n"
+    fprintf(output, _("  \\pset [NAME [VALUE]]     set table output option\n"
                       "                         (NAME := {format|border|expanded|fieldsep|fieldsep_zero|footer|null|\n"
                       "                         numericlocale|recordsep|recordsep_zero|tuples_only|title|tableattr|pager|\n"
                       "                         unicode_border_linestyle|unicode_column_linestyle|unicode_header_linestyle})\n"));


Why above changes reqired ?

3) This patch adding IF NOT EXIST_S for CREATE TABLE AS and CREATE MATERIALIZED
TABLE, but testcase coverage for CREATE MATERIALIZED TABLE is missing.

Apart from this changes looks good to me.