On Mon, Nov 14, 2022 8:08 PM Melih Mutlu <m.melihmutlu@gmail.com> wrote: 1. +# Binary enabled subscription should fail +$node_subscriber_binary->wait_for_log("ERROR: insufficient data left in message");
Should it be changed to "ERROR: ( [A-Z0-9]+:)? ", like other subscription tests.
Done.
2. +# Binary disabled subscription should succeed +$node_publisher->wait_for_catchup('tap_sub');
If we want to wait for table synchronization to finish, should we call wait_for_subscription_sync()?
Done.
3. I also think it might be better to support copy binary only for publishers of v16 or later. Do you plan to implement it in the patch?