Postgres Pro
Downloads
Home   >   mailing lists

Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases
Date
Msg-id CAGPVpCQd9G0w988zD9akUKpwXNjJwdA511+KW9Mn3OL_U6L=eg@mail.gmail.com
Whole thread Raw
In response to Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases
List pgsql-hackers
Tree view
Hi,

Masahiko Sawada <sawada.mshk@gmail.com>, 8 May 2023 Pzt, 10:24 tarihinde şunu yazdı:
I've attached the patch. Feedback is very welcome.

Thanks for the patch, nice catch.
I can confirm that the issue exists on HEAD and gets resolved by this patch. Also it looks like stats are really not affected if transaction fails for some reason, as you explained.
IMO, the patch will be OK after commit message is added.

Thanks,
--
Melih Mutlu
Microsoft

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Next
From: Michael Paquier
Date:
Subject: Re: WAL Insertion Lock Improvements