Re: Enumize logical replication message actions - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Enumize logical replication message actions
Date
Msg-id CAGEoWWRWeRi8=-NiXxnee7PtC3bNKyJ7j97XEO6AyQr30Y8Xow@mail.gmail.com
Whole thread Raw
In response to Re: Enumize logical replication message actions  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers


On Thu, Nov 26, 2020 at 10:15 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Nov 25, 2020 at 2:52 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Nov 25, 2020 at 2:26 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Hackers.
> >
> > Last month there was a commit [1] for replacing logical replication
> > message type characters with enums of equivalent values.
> >
> > I was revisiting this code recently and I think due to oversight that
> > initial patch was incomplete. IIUC there are several more enum
> > substitutions which should have been made.
> >
> > PSA my patch which adds those missing substitutions.
> >
>
> Good catch. I'll review it in a day or so.
>

The patch looks good to me and I have pushed it.

Thanks Peter and Amit for noticing the missing substitutions and fixing those.  

--
Best Wishes,
Ashutosh

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add table access method as an option to pgbench
Next
From: Bharath Rupireddy
Date:
Subject: Re: Multi Inserts in CREATE TABLE AS - revived patch