Re: CI: Add task that runs pgindent - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: CI: Add task that runs pgindent
Date
Msg-id CAGECzQQSaOp-W6gbNnSdVtNCoOdOiOb+1wO=P8hcC-yvM2Xifg@mail.gmail.com
Whole thread Raw
In response to Re: CI: Add task that runs pgindent  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: CI: Add task that runs pgindent
List pgsql-hackers
On Tue, 21 Oct 2025 at 15:27, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 21 Oct 2025, at 15:22, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>
> > Do you think that this task should format perl files as well?
>
> +1, if we do this we should run pgperltidy as well.

I definitely agree that we should run that too. But currently the
master branch isn't correctly formatted according to pgperltidy (at
least with the pgperltidy on my machine I get a bunch of changes). So
I guess koel doesn't complain about that yet, and I didn't want to
conflate possible objectsions to that with objections to running
pgindent in CI. Once this CI job is in I wanted to start that
discussion for pgindent (and similarly a discussion on adding a python
formatter/linter).



pgsql-hackers by date:

Previous
From: "Matheus Alcantara"
Date:
Subject: Re: postgres_fdw: Use COPY to speed up batch inserts
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: CI: Add task that runs pgindent