Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
Date
Msg-id CAG7mmozwV51hVVPpNx5A6Q184bMvvdbE-iC6FSO-A1oL2J6iEw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks - committed!

Thanks Arun for the quick review!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

More specifically to the issue.
I am using SqlFieldControl in View for Definition Field which takes default height of 300px which is set by Control as default height. but as per dave's suggestion on thread


"The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".

If user still need some height for control, It can be specified in extraclasses[] parameter which will apply to the specific field.



On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

The SqlFieldControl is setting default height for textarea, which is not needed.
It should expand as needed as similar in SqlTabControl.

Please find the attached patch, review it.

Thanks
Surinder Kumar


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Remove unnecessary extra classes set in the SqlFieldC
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Show the resize handle on the alertify dialog.