Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename
Date
Msg-id CAG7mmozN9d8Rk0Y--Jx5mg=x-4MbBq1rVXRg5Pfw732oH8Ht5Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view

On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please? Thanks.

On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .
RM#2355
We should remove the existing node, and then insert at right place instead of refreshing the parent.
Because - that will select the parent node, and not that node, and also - it adds overhead of refreshing the whole parent node.

Please send the patch as per our discussion.

-- Thanks, Ashesh

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting bysize is broken
Next
From: Ashesh Vashi
Date:
Subject: Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum