Re: Patch for SonarQube code scan fixes - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: Patch for SonarQube code scan fixes
Date
Msg-id CAG7mmoz-zbxZqx0B+w42Jfo9a=6Nk5_xj2gbWTL9BgdJGgsAew@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Responses Re: Patch for SonarQube code scan fixes  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers

On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Functions files:
  • Remove the unused local variable "args"
2. node.js file in browser/static:
  • "j" hides or potentially hides a variable declared in an outer scope at line 1080.
This is a common file between pgAdmin & PEM.
Please send a patch to the pgadmin team. 
3. FTS Templates files:
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
This is a common file between pgAdmin & PEM.
Please send a patch to the pgadmin team.  
4. FTS Parsers files:
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
This is a common file between pgAdmin & PEM.
Please send a patch to the pgadmin team. 
5. FTS Dictionaries files:
  • Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
This is a common file between pgAdmin & PEM.
Please send a patch to the pgadmin team.  
6. FTS Configurations files:
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
This is a common file between pgAdmin & PEM.
Please send a patch to the pgadmin team. 

-- Thanks, Ashesh

Regards,
Nikhil Mohite.

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: Patch for SonarQube code scan fixes
Next
From: Dave Page
Date:
Subject: Re: Patch for SonarQube code scan fixes