Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] fix newly added server being lost when crashing - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [PATCH] fix newly added server being lost when crashing
Date
Msg-id CAG7mmoyfRG9v8VKqHhBXw=Wy-MzHEqRKHZ8QKPG6TGw3GBbf=w@mail.gmail.com
Whole thread Raw
In response to [PATCH] fix newly added server being lost when crashing  (Kaarel Moppel <kaarel.moppel@gmail.com>)
Responses Re: [PATCH] fix newly added server being lost when crashing  (Kaarel Moppel <kaarel.moppel@gmail.com>)
List pgadmin-hackers
Tree view
Hi Kaarel,

I think - everything looks good except:
1. Please use TAB instead of 4 spaces
2. You don't require to define Flush function after inheriting the wxConfig class publicly.
     Or,
    Define it only if you keep the wxConfig inherited protectively.


On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel.moppel@gmail.com> wrote:
Hi,

Sending some 3 small fixes in separate emails for issues that me and my colleagues found really annoying. This is my first try at Pgadmin and I haven't done too much C++ though so in case something should be corrected let me know and I'd be happy to do that.

Cheers,
Kaarel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [PATCH] fix newly added server being lost when crashing
Next
From: "J.F. Oster"
Date:
Subject: Re: PATCH: Improve status bar in Edit Data window