Re: PATCH: To fix minor patches (pgAdmin4) - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: PATCH: To fix minor patches (pgAdmin4)
Date
Msg-id CAG7mmoxXRbZer1d2RZKLcu3u2o7Nhmg8GHNtsrF6pUOsbyQsvA@mail.gmail.com
Whole thread Raw
In response to PATCH: To fix minor patches (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: PATCH: To fix minor patches (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers

On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA minor patches to fix RM#1234, RM#1279.
I've committed the fix for RM#1276.

But - Proposed fix for RM#1234 does not look right to me.

Consider a name, value has ';' (semicolon) within it, the SQL will generated will be wrong.
i.e. Put a semicolon in comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

 

 
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixes #1276 - Resolved an issue - 'TypeError: c is un
Next
From: Ashesh Vashi
Date:
Subject: Re: PATCH: To fix the issue in type node (pgAdmin4)