Postgres Pro
Downloads
Home   >   mailing lists

Re: [Pgadmin] [Docker] servers.json import fails when running indesktop mode - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [Pgadmin] [Docker] servers.json import fails when running indesktop mode
Date
Msg-id CAG7mmow_n3Gn0xz7FRFktg20jza8jJSJnMRKg7Xd6=NYBXmhsw@mail.gmail.com
Whole thread Raw
In response to [Pgadmin] [Docker] servers.json import fails when running indesktop mode  (Levitt Olivier <olivier.levitt@insee.fr>)
Responses RE: [Pgadmin] [Docker] servers.json import fails when running indesktop mode  (Levitt Olivier <olivier.levitt@insee.fr>)
List pgadmin-hackers
Tree view


On Sat, Dec 14, 2019 at 3:53 AM Levitt Olivier <olivier.levitt@insee.fr> wrote:
Hi,

When running the docker image in desktop mode (PGADMIN_CONFIG_SERVER_MODE=False), no user is created. That is expected behaviour.
But then the code that imports the servers.json pre-configuration fails as it ties the import to the default user. 

I think line 40 of entrypoint.sh (https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=pkg/docker/entrypoint.sh;h=47d14bf2d415777c64b221fb1fc75d61c5e3cecc;hb=HEAD) should not specify a user when running in dekstop mode.
I tested it without --user parameter and it successfully imported the servers.json configuration.

Should I submit a patch ? First time contributing to Pgadmin :)
Please do.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



Regards,
Olivier Levitt


pgadmin-hackers by date:

Previous
From: Levitt Olivier
Date:
Subject: [Pgadmin] [Docker] servers.json import fails when running indesktop mode
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixed any typo - we were using the function