Postgres Pro
Downloads
Home   >   mailing lists

Re: Dialogues not closing - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: Dialogues not closing
Date
Msg-id CAG7mmow_OwW2YeBT_Br6Tjm_bQMthAxzecvetRq5h8C725wRbA@mail.gmail.com
Whole thread Raw
In response to Re: Dialogues not closing  (Dave Page <dpage@pgadmin.org>)
Responses Re: Dialogues not closing  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view

Hi Dave,


On Fri, Apr 15, 2016 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:



On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Fri, Apr 15, 2016 at 2:23 AM, Dave Page <dpage@pgadmin.org> wrote:

Hey Ashesh,

We have an issue with dialogues not closing on Save button presses.
One of the team told me yesterday or the day before that it's a
general issue, not one specific to the patch I was reviewing at the
time, which I've been finding seems to be the case.

Any idea what this issue is?
Sure - I will look into it.

Thanks - please make it a priority; I'm at PG Conf NYC next week and expect to be doing lots of demos. 
Please find the patch for the same.

This also includes some of the cleanup required to solve some of the memory leak issues.

I was not able to reproduce the issue at my end, but - I've idea of when it could fail to close the panel, which I have resolved in this patch.
Can you please test it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool
Next
From: Harshal Dhumal
Date:
Subject: Initial Check constraint node patch [Pgadmin4]