Request a Demo
Home   >   mailing lists

Re: [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE - Mailing list pgsql-hackers

From Sho Ito
Subject Re: [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE
Date
Msg-id CAG7L5+6tk0vGmB07mdNd6mdt1048CdeMO=jA1MOEi6M2xzqyJg@mail.gmail.com
Whole thread
In response to [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE  (Haruna Miwa <miwa@sraoss.co.jp>)
Responses Re: [PATCH] psql: avoid CREATE command completion after GRANT/REVOKE CREATE
List pgsql-hackers
Tree view
Hi Haruna,

I tested the patch and confirmed that `GRANT CREATE` and `REVOKE CREATE` now complete to `ON` as expected, including lowercase input.

I also found that `REVOKE GRANT OPTION FOR CREATE` should reach the same privilege-completion rule, but the earlier `TailMatches("CREATE")` branch still intercepts it and offers CREATE object types instead of `ON`.

Perhaps it would be a good idea to cover this form in the same patch. What do you think?

Thanks,
Sho Ito

On Sun, Oct 4, 2026 at 5:57 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
Hi,

While testing psql tab completion, I noticed that the generic CREATE
completion rule is triggered after GRANT CREATE and REVOKE CREATE.

This results in irrelevant CREATE object type suggestions being offered
in those contexts.

I created a patch to exclude GRANT CREATE and REVOKE CREATE from the
generic CREATE completion rule.

Regards,

Haruna Miwa

--
Haruna Miwa


--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
Sho Ito (Sean)

＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝

pgsql-hackers by date:

Previous
From: Joao Detomini
Date:
Subject: Limiting WAL retained for archiving, like max_slot_wal_keep_size
Next
From: Stefan Guha
Date:
Subject: Re: Planning time quadratic in the IN-list length for "c = X AND (a, b) IN (...)" with BitmapOr