Re: PostgreSQL 17 release announcement draft - Mailing list pgsql-advocacy
| From | Andrew Atkinson |
|---|---|
| Subject | Re: PostgreSQL 17 release announcement draft |
| Date | |
| Msg-id | CAG6XLEk4=W5VLSuNj9p3uq=R=-aizR8P8d4EhVZmjsnE6kGUFg@mail.gmail.com Whole thread Raw |
| In response to | Re: PostgreSQL 17 release announcement draft (Adrian Klaver <adrian.klaver@aklaver.com>) |
| List | pgsql-advocacy |
This is looking crisper. Nice edits! I did one more read through and have minor comments and suggestions.
----------------------
> "PostgreSQL 17 introduces a new internal memory structure for vacuum
was used that consumes up to 20x less memory"
Small typo, I think "that" was missed:
PostgreSQL 17 introduces a new internal memory structure for vacuum that consumes up to 20x less memory.
"This release expands on functionality for managing data in partitions or
federated on remote PostgreSQL instances."
Alternative: "This release expands on functionality for managing data in partitions or data spread out between local and remote PostgreSQL instances."
was used that consumes up to 20x less memory"
Small typo, I think "that" was missed:
PostgreSQL 17 introduces a new internal memory structure for vacuum that consumes up to 20x less memory.
----------------------
> "and PostgreSQL 17 adds to its implementation SQL/JSON standard."
is this missing "of the" ?
and PostgreSQL 17 adds to its implementation "of" the SQL/JSON standard.
is this missing "of the" ?
and PostgreSQL 17 adds to its implementation "of" the SQL/JSON standard.
----------------------
"exporting,including"
add space after "exporting", assuming this was copied correctly from the source file into google docs (which it may not have been) :)
add space after "exporting", assuming this was copied correctly from the source file into google docs (which it may not have been) :)
----------------------
This is in the realm of personal preference/suggestion. The word "federated" is complex and I kind of understand it, but prefer simpler terminology. Here's a suggestion:
"This release expands on functionality for managing data in partitions or
federated on remote PostgreSQL instances."
Alternative: "This release expands on functionality for managing data in partitions or data spread out between local and remote PostgreSQL instances."
----------------------
Suggestion: both "converts" and "creates" verbs are used in the docs to describe pg_createsubscriber. I like the verb "convert" because I think it speaks more to the purpose of being run on a physical replica, then turning it into a logical replication based instance as a subscriber.
With that said, my suggested alternative is:
PostgreSQL 17 introduces the
[`pg_createsubscriber`](https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html)
command-line tool which can be used to convert a physical replica into a logical replica.
With that said, my suggested alternative is:
PostgreSQL 17 introduces the
[`pg_createsubscriber`](https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html)
command-line tool which can be used to convert a physical replica into a logical replica.
----------------------
> "which allows you to give users permission to execute maintenance operations."
Suggested simplifications:
which gives users the permissions needed to perform maintenance operations.
Suggested simplifications:
which gives users the permissions needed to perform maintenance operations.
which provides permissions for maintenance operations.
----------------------
> "the [`pg_combinebackup`](https://www.postgresql.org/docs/17/app-pgcombinebackup.html)
or the backup restoration process"
I thought the "or" here was maybe a mistake. Maybe it was meant to be "of". With that said, I pulled in the verb "reconstruct" the docs use. It's a fun verb and I know it coudl be translated to Spanish as reconstruir :)
Suggestion:
the [`pg_combinebackup`](https://www.postgresql.org/docs/17/app-pgcombinebackup.html)
tool to reconstruct a full backup.
or the backup restoration process"
I thought the "or" here was maybe a mistake. Maybe it was meant to be "of". With that said, I pulled in the verb "reconstruct" the docs use. It's a fun verb and I know it coudl be translated to Spanish as reconstruir :)
Suggestion:
the [`pg_combinebackup`](https://www.postgresql.org/docs/17/app-pgcombinebackup.html)
tool to reconstruct a full backup.
----------------------
> "reports the [progress of vacuuming indexes](https://www.postgresql.org/docs/17/progress-reporting.html#VACUUM-PROGRESS-REPORTING),
and adds the [`pg_wait_events`](https://www.postgresql.org/docs/17/view-pg-wait-events.html)
For the system views, is the standard to refer to them without using the words system view? If so, it's fine here. If not, I think it's missing that.
Suggestion: "adds the `pg_wait_events` system view" (or "view")
and adds the [`pg_wait_events`](https://www.postgresql.org/docs/17/view-pg-wait-events.html)
For the system views, is the standard to refer to them without using the words system view? If so, it's fine here. If not, I think it's missing that.
Suggestion: "adds the `pg_wait_events` system view" (or "view")
----------------------
"Many other new features and improvements have been added to PostgreSQL 17. Many
of these may also be helpful for your use cases."
Recommend consolidating these two sentences.
of these may also be helpful for your use cases."
Recommend consolidating these two sentences.
----------------------
"## Licence" is the british english spelling intended here?
----------------------
Looks great! I even learned about more new features in this revised version! I checked the links and saw "17" everywhere I'd expect to see it.
On Fri, Sep 6, 2024 at 12:28 PM Adrian Klaver <adrian.klaver@aklaver.com> wrote:
On 9/6/24 10:03 AM, Jonathan S. Katz wrote:
> On 9/5/24 3:21 PM, Andrew Atkinson wrote:
> Please see v2 attached. As per original note, please provide feedback
> before Mon, Sep 9 @ 12:00 UTC so we can begin the translation process.
A quick read through found:
"... the
[`pg_combinebackup`](https://www.postgresql.org/docs/17/app-pgcombinebackup.html)
or the backup restoration process."
I'm guessing that is "... for the backup restoration process."
>
> Thanks,
>
> Jonathan
--
Adrian Klaver
adrian.klaver@aklaver.com
pgsql-advocacy by date: