Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

Hi,

On Sun, Oct 4, 2026 at 5:01 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
>
> And without fix shared as a v77-0003 [1], this would error out with
> below error[2], I have explained the reason [1].  I have added a
> testcase in 035_conflicts.pl file in v79-0003 patch for this issue.

Thanks for updating the patches.

I've started reviewing the 0001 patch and would like to suggest some refactoring
to simplify the code in ReportApplyConflict(). The idea is to move the fallback
logic into get_conflictlog_dest_and_table() so the caller's code looks cleaner.

And I think we could build the errdetail for both the table and
logfile cases and call ereport() only once, to reduce the duplicated code.

Please check the attached follow-up patches (on top of 0001), I hope it makes
the code better.(1 file changed, 33 insertions(+), 58 deletions(-))

Best Regards,
Zhijie Hou