Re: Postgres_fdw join pushdown - wrong results with whole-row reference - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Date
Msg-id CAFjFpRefDr5_tsfegQeg-=D5Jc7hd-yAmLnuiyN4WVGL6eX-eA@mail.gmail.com
Whole thread Raw
In response to Re: Postgres_fdw join pushdown - wrong results with whole-row reference  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Postgres_fdw join pushdown - wrong results with whole-row reference  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers


I think the proposed idea of applying record::text explicit coercion to a whole-row reference in the IS NOT NULL condition in the CASE WHEN conversion would work as expected as you explained, but I'm concerned that the cost wouldn't be negligible when the foreign table has a lot of columns.

That's right, if the foreign server doesn't optimize the case for IS NOT NULL, which it doesn't :)

I am happy to use any cheaper means e.g a function which counts number of columns in a record. All we need here is a way to correctly identify when a record is null and not null in the way we want (as described upthread). I didn't find any quickly. Do you have any suggestions?


--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)
Next
From: Craig Ringer
Date:
Subject: Re: PQconnectdbParams vs PQconninfoParse