Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type
Date
Msg-id CAFjFpRdG4QrYhnpKJvvJhp6ThrfUm9Bej1mk5TqaA1n6Bx5TiQ@mail.gmail.com
Whole thread Raw
In response to jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as booltype  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Apr 26, 2018 at 9:04 AM, Haribabu Kommi
<kommi.haribabu@gmail.com> wrote:
> The jitflags in the PlannedStmt structure of type "int", but in _out and
> _read functions it is treated as of "bool" type.
>
> WRITE_BOOL_FIELD(jitFlags);
> READ_BOOL_FIELD(jitFlags);
>
> I am thinking of it is a copy paste mistake as the other members around the
> initflags are of "bool" type or is there any specific reason to treat as
> "bool" type?

No, I don't see any. Here's patch for the same.

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: WIP: a way forward on bootstrap data
Next
From: Amit Langote
Date:
Subject: Re: minor fix for acquire_inherited_sample_rows