Re: review: CHECK FUNCTION statement - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: review: CHECK FUNCTION statement
Date
Msg-id CAFj8pRDCbsqjRwC45ZQ-6LSFvMF2pv7b+6Hgu4u3=QO0yJ2BLA@mail.gmail.com
Whole thread Raw
In response to Re: review: CHECK FUNCTION statement  ("Albe Laurenz" <laurenz.albe@wien.gv.at>)
Responses Re: review: CHECK FUNCTION statement
List pgsql-hackers
Hello

2011/12/12 Albe Laurenz <laurenz.albe@wien.gv.at>:
> Pavel Stehule wrote:
>> there is merged patch
>
> Works fine, except that there are still missing const qualifiers
> in copyfuncs.c and equalfuncs.c that lead to compiler warnings.
>
> One thing I forgot to mention:
> I thought there was a consensus to add a WITH() or OPTIONS() clause
> to pass options to the checker function:
> http://archives.postgresql.org/message-id/12568.1322669638@sss.pgh.pa.us
>
> I think this should be there so that the API does not have to be
> changed in the future.
>

changes:

* fixed warnings
* support for options - actually only two options are supported -
quite and fatal_errors

these options are +/- useful - main reason for their existence is
testing of  support of options - processing on CHECK ... stmt side and
processing on checker function side.

options are send as 2d text array - some like
'{{quite,on},{fatal_errors,on}} - so direct call of checker function
is possible

* regress test for multi check

Regards

Pavel

> Yours,
> Laurenz Albe

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: NOTIFY with tuples
Next
From: Shigeru Hanada
Date:
Subject: Re: WIP: Collecting statistics on CSV file data