Re: proposal: row_to_array function - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: proposal: row_to_array function
Date
Msg-id CAFj8pRBzt9CwshdkJ8NwPnNi-JbzgWv4pz+ni5UR0606erPcVQ@mail.gmail.com
Whole thread Raw
In response to Re: proposal: row_to_array function  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: proposal: row_to_array function
List pgsql-hackers
Hi

I tested a concept iteration over array in format [key1, value1, key2, value2, .. ] - what is nice, it works for [[key1,value1],[key2, value2], ...] too

It is only a few lines more to current code, and this change doesn't break a compatibility.

Do you think, so this patch is acceptable?

Ideas, comments?

Regards

Pavel


2015-01-16 22:35 GMT+01:00 Andrew Dunstan <andrew@dunslane.net>:

On 01/16/2015 12:22 PM, Pavel Stehule wrote:


        There two possible transformations:

        row_to_array --> [[key1, value1],[key2, value2], ...]
        row_to_row_array --> [(key1, value1), (key2, value2), ... ]


    If we're going to go that route, I think it makes more sense to
    create an actual key/value type (ie:
    http://pgxn.org/dist/pair/doc/pair.html) and return an array of that.


ok

    <http://BlueTreble.com>



I think we'd possibly be better off with simply returning a flat array, [key1, value1, ...]

Thats's what the hstore(text[]) and json_object(text[]) functions accept, along with the 2D variant, if we want a precedent.

cheers

andrew


Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Shortcoming in CLOBBER_FREED_MEMORY coverage: disk buffer pointers
Next
From: Andrew Gierth
Date:
Subject: Re: Re: Abbreviated keys for Datum tuplesort