Postgres Pro
Downloads
Home   >   mailing lists

Re: broken master regress tests - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: broken master regress tests
Date
Msg-id CAFj8pRBqtDWOa0b04F40pvmHyfkoADD2wOx3OMuWtppeN-5J=g@mail.gmail.com
Whole thread Raw
In response to Re: broken master regress tests  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Tree view
Hi

so 26. 8. 2023 v 23:52 odesílatel Thomas Munro <thomas.munro@gmail.com> napsal:
On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> So it looks so IPC::Run::run is ignore parent environment

I guess the new initdb template captures lc_messages in
postgresql.conf, when it runs earlier?  I guess if you put
$node->append_conf('postgresql.conf', 'lc_messages=C'); into
src/bin/pg_amcheck/t/003_check.pl then it will work.  I'm not sure
what the correct fix should be, ie if the template mechanism should
notice this difference and not use the template, or if tests that
depend on the message locale should explicitly say so with
lc_messages=C or similar (why is this the only one?), or ...

diff --git a/src/bin/pg_amcheck/t/003_check.pl b/src/bin/pg_amcheck/t/003_check.pl
index d577cffa30..ba7c713adc 100644
--- a/src/bin/pg_amcheck/t/003_check.pl
+++ b/src/bin/pg_amcheck/t/003_check.pl
@@ -122,6 +122,7 @@ sub perform_all_corruptions()
 $node = PostgreSQL::Test::Cluster->new('test');
 $node->init;
 $node->append_conf('postgresql.conf', 'autovacuum=off');
+$node->append_conf('postgresql.conf', 'lc_messages=C');
 $node->start;
 $port = $node->port;

it fixes this issue

Regards

Pavel

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: Extract numeric filed in JSONB more effectively
Next
From: "Rui Zhao"
Date:
Subject: Re: pg_upgrade fails with in-place tablespace