Postgres Pro
Downloads
Home   >   mailing lists

Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date
Msg-id CAFj8pRBQOC4LZmYenGtpZAS=Vt+YTbc8s1UQXTEtcNmVegOv5g@mail.gmail.com
Whole thread Raw
In response to Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Tree view
Hello

here is patch with fault tolerant drop trigger and drop rule support

drop trigger [if exists] trgname on [if exists] tablename;
drop rule [if exists] trgname on [if exists] tablename;

Regards

Pavel



2013/11/11 Pavel Stehule <pavel.stehule@gmail.com>



2013/11/11 Tom Lane <tgl@sss.pgh.pa.us>
Andres Freund <andres@2ndquadrant.com> writes:
> Turns out that's bogus - ALTER TABLE has two levels of NOT EXISTS.

> Maybe we should just do the same for DROP TRIGGER?

> DROP TRIGGER [ IF EXISTS ] name ON table_name [ IF EXISTS ] [ CASCADE | RESTRICT ]

Works for me.

for me too

tomorrow I'll prepare patch

Regards

Pavel
 

                        regards, tom lane


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Attachment

pgsql-hackers by date:

Previous
From: J Smith
Date:
Subject: Errors on missing pg_subtrans/ files with 9.3
Next
From: Bruce Momjian
Date:
Subject: Re: Patch for fail-back without fresh backup