On Wed, Jul 6, 2022 at 2:32 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Tue, Jul 5, 2022 at 4:33 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > I thought about this comment from Robert
> > > that's not quite the same as either of those things. For example, in
> > > tableam.h we currently say "This callback needs to create a new
> > > relation filenode for `rel`" and how should that be changed in this
> > > new naming? We're not creating a new RelFileNumber - those would need
> > > to be allocated, not created, as all the numbers in the universe exist
> > > already. Neither are we creating a new locator; that sounds like it
> > > means assembling it from pieces.
> >
> > I think that "This callback needs to create a new relation storage
> > for `rel`" looks better.
>
> I like the idea, but it would sound better to say "create new relation
> storage" rather than "create a new relation storage."
Okay, changed that and changed a few more occurrences in 0001 which
were on similar lines. I also tested the performance of pg_bench
where concurrently I am running the script which creates/drops
relation but I do not see any regression with fairly small values of
VAR_RELNUMBER_PREFETCH, the smallest value I tried was 8. That
doesn't mean I am suggesting this small value but I think we can keep
the value something like 512 or 1024 without worrying much about the
performance, so changed to 512 in the latest patch.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
